Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#272 closed defect (fixed)

[PATCH] Correct parsing for .desktop files

Reported by: Nathan Rennie-Waldock Owned by:
Priority: minor Milestone:
Component: Global Keywords:
Cc:

Description

I've updated load_desktop_menus to use ConfigParser?. I've been using this patch for a couples months and had no issues, menus behave as expected.

Attachments (1)

load_desktop_menus - use ConfigParser.patch​ (3.8 KB) - added by Nathan Rennie-Waldock 9 years ago.

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by Nathan Rennie-Waldock

Attachment: load_desktop_menus - use ConfigParser.patch​ added

comment:1 Changed 9 years ago by Antoine Martin

Resolution: → fixed
Status: new → closed

Looks good, why do you need this? Does this fix a bug?

What would be even better would be to use ​pyxdg, as per #94. I wished I had known about both of these libraries when I first wrote winswitch..

Applied anyway in r5301.

comment:2 Changed 9 years ago by Nathan Rennie-Waldock

More reliable fix for #268. It'd handle badly ordered .desktop files (which shouldn't happen but safer to anyway).

Note: See TracTickets for help on using tickets.