Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#65 closed defect (wontfix)

the newer GTK builds for win32 do not support ICO format - workaround it

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 0.9.1
Component: Client Keywords:
Cc:

Description (last modified by Antoine Martin)

Added a test for it so we dont flood the logs (r1523)

GError: This build of gdk-pixbuf does not support saving the image format: ico

But we should either save it in png format (and hope the user's version of windows supports that or at least fails gracefully) or find a library that will convert it to ico (not found so far - only reading is supported, see PIL, etc)

Maybe pywin32 can give us access to something in windows API that will do the job, this is not too far off (it's only reading though).

Found Icon.Save in .NET

this example writes it out straight to file.
Newer versions of windows support icons as PNGs, we should at least do that when saving .ICO fails.

Change History (8)

comment:1 Changed 9 years ago by Antoine Martin

Description: modified (diff)
Owner: changed from Antoine Martin to Antoine Martin
Status: newaccepted

comment:2 Changed 9 years ago by Antoine Martin

Description: modified (diff)

comment:3 Changed 9 years ago by Antoine Martin

Description: modified (diff)

comment:4 Changed 9 years ago by Antoine Martin

Description: modified (diff)

comment:5 Changed 9 years ago by Antoine Martin

done the PNG fallback in r1548

Last edited 8 years ago by Antoine Martin (previous) (diff)

comment:6 Changed 9 years ago by Antoine Martin

Milestone: 1.00.9.1

comment:7 Changed 9 years ago by Antoine Martin

Resolution: wontfix
Status: acceptedclosed

reverted to old gtk version as newer versions break xpra, see bug #71

comment:8 Changed 8 years ago by Antoine Martin

Description: modified (diff)
Note: See TracTickets for help on using tickets.