Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#266 closed defect (fixed)

xpra v0.14.6-2 not working

Reported by: Nathan Rennie-Waldock Owned by: Nathan Rennie-Waldock
Priority: major Milestone:
Component: Xpra Keywords:
Cc:

Description

xpra isn't working in 0.12.20
Server is Ubuntu 12.04 64bit, client is Windows 7 64bit
Both run WinSwitch? 0.12.20. Server's xpra is v0.14.6-2

Part of server log:

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/xpra/server/server_core.py", line 434, in _process_hello
    proto.enable_compressor_from_caps(c)
  File "/usr/lib/python2.7/dist-packages/xpra/net/protocol.py", line 383, in enable_compressor_from_caps
    self.enable_nocompress()
AttributeError: 'Protocol' object has no attribute 'enable_nocompress'
2014-09-18 15:06:53,999 connection timedout: Protocol(SocketConnection(('127.0.0.1', 15063) - ('127.0.0.1', 50844)))
2014-09-18 15:06:54,799 Connection lost

I've downgraded xpra to 0.13.9-1 and that's working.

Attachments (1)

caps.log (13.6 KB) - added by Nathan Rennie-Waldock 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 5 years ago by Nathan Rennie-Waldock

From the code around there, it looks like self.enable_nocompress() should be self.enable_compressor("none")
After that change, it's working again. But shouldn't zlib be working? I added log("enable_compressor_from_caps(%s): opts = %s", caps, opts) to enable_compressor_from_caps, it shows zlib and lz4 are enabled for server, but not in client's capabilities. Attached output.

Changed 5 years ago by Nathan Rennie-Waldock

Attachment: caps.log added

comment:2 Changed 5 years ago by Antoine gmail

You're right, sorry about that.

I didn't notice because I have python-lz4 or at the very least python-lzo installed.
Your fix is correct for the "none" compressor, applied: http://xpra.org/trac/changeset/7688

As for zlib, it should be enabled but is somehow missing from the caps, I'm looking into it. Will backport both fixes to xpra v0.14.x

comment:3 Changed 5 years ago by Antoine gmail

I can't remember the xpra version shipped with winswitch, it needs updating.
Maybe it doesn't send zlib=1?

comment:4 Changed 5 years ago by Nathan Rennie-Waldock

xpra is 0.10.11, really could do with an update.
Apparently not, but at least I've got it working with no compression.

comment:5 Changed 5 years ago by Antoine gmail

OK, it seems that older versions of xpra didn't send zlib=1, including the version you have which is shipped bundled with winswitch. I'll add an ugly workaround to 0.14.x and later.

FYI: there is a new winswitch 0.12.20 build (same version, newer build number) which includes xpra 0.11.1, which does not have this problem: http://xpra.org/dists/windows/
You can use that in the meantime.

comment:6 Changed 5 years ago by Antoine gmail

Owner: set to Nathan Rennie-Waldock
Status: newassigned

The fix for zlib=1 is in http://xpra.org/trac/changeset/7691/xpra, it is for 0.14.x only because 0.15 will drop compatibility with versions older than 0.12 anyway.

Does that work for you? (it should allow zlib to be enabled with older clients, like the one you were using)
Can I close this ticket?

(I do intend to make a new winswitch build before too long, definitely before 0.15 comes out)

comment:7 Changed 5 years ago by Nathan Rennie-Waldock

Resolution: fixed
Status: assignedclosed
68/xpra.log:2014-09-18 16:54:54,653 client has requested compression level=1
68/xpra.log-2014-09-18 16:54:54,653 add_packet_to_queue(set_deflate ...)

That seems to work, thanks.

Last edited 5 years ago by Nathan Rennie-Waldock (previous) (diff)
Note: See TracTickets for help on using tickets.