--open_server_config bugs

[pmarek]

winswitch 0.12.15, debian package

winswitch_applet --open_server_config= has these bugs:

• the applet.log gets rotated; call it twice, and the running applet logs into a deleted file.
• it doesn't connect; the winswitch menu shows the server as connected, but the sessions are not resumed, and clicking on "resume" just makes the server-menu show up disconnected again.

Generally I'd like to say "connect to server X, session named Y" - where X can contain the "​ssh://" indicator, for example.

Perhaps a dbus interface would be better?

[Antoine Martin]

the log rotation was #196 - I am very tempted to just remove the feature at this point, not worth the hassle

Not sure why you expect the sessions to be resumed? did you set auto-connect for that server?

[pmarek]

Please keep the log-rotation - that was my request, too. Perhaps it should only be done _after_ daemonizing ...

Yes, auto-resume is set - and I'd like a way to connect to xpra sessions via symbolic names, ie. using server/session name instead of server/xpra session number.

Using the config file (which has server + session number) doesn't work, too - I'd have to parse the needed data, and call xpra (with all options!) manually.

[Antoine Martin]

The log rotation issue is fixed in r4999 by naming the log files with the datetime, and rotating only on exit. We cannot rotate later during startup because we would lose useful log messages.

As for the other issue: yes, why is this server config not loaded already? Are you using this feature to trigger a connection to a server which is already in the list?

[pmarek]

Yes, the server is already in the list. I just want to get the session restored via a shell script.

[Antoine Martin]

Just tested auto-resume and it worked fine for me.

However, I just found one case where the server had not detected that the session was 'available' and it was shown as 'connected' still, in this case the session was not resumed. Could this be what you are seeing?

[pmarek]

I don't think so. I've seen that one, too; but my report is about a different case.

In my case winswitch has seen all connections broken for some time (~30mins) - so the menu shows servername => connect for every entry.

Then I call the CLI for one of these sessions; the server goes to state "connected" and has "resume 1 sessions" in the menu, but isn't really connected - choosing the "resume" menu item makes the server go back to "disconnected" appearance.

Choosing "connect" from the server menu works - it connects and auto-resumes the session, but with --open_server_config something seems broken.

[Antoine Martin]

Sounds like your #203, I cannot reproduce here and this seems linked to your use of unreliable ssh tunnels. Will close unless I can reproduce.