Opened 7 years ago

Closed 7 years ago

#186 closed defect (fixed)

config apply_changes triggers error in rdp_client_base

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 0.12
Component: Client Keywords:
Cc:

Description

as reported by @pmarek on irc:

ConfigureAppletWindow.apply_changes()
Traceback (most recent call last):
 File "winswitch/ui/config_common.py", line 621, in apply_changes
  self.do_apply_changes()
 File "winswitch/ui/config_applet.py", line 1014, in do_apply_changes
  self.applet.settings_modified()
 File "winswitch/client/applet.py", line 757, in settings_modified
  self.init_client_utils()
 File "winswitch/client/client_base.py", line 356, in init_client_utils
  self.client_utils[session_type] = constructor()
 File "winswitch/client/client_base.py", line 338, in rdp_common
 return     RDPClientUtil(self.update_session_status, self.notify)
 File "winswitch/virt/rdp_client_util.py", line 18, in __init__
  RDPClientBase.__init__(self, update_session_status, notify_callback)
 File "winswitch/virt/rdp_client_base.py", line 38, in __init__
  ClientUtilBase.__init__(self, WINDOWS_TYPE, update_session_status, notify_callback)
 File "winswitch/virt/client_util_base.py", line 48, in __init__
  self.options_defaults = self.load_options_defaults()
 File "winswitch/virt/client_util_base.py", line 58, in load_options_defaults
  props = self.get_options_defaults()
 File "winswitch/virt/rdp_client_base.py", line 373, in get_option
  props = self.get_options_defaults()
 File "winswitch/virt/rdp_client_base.py", line 373, in get_options_defaults
  d[KEYMAP] = self.get_default_keymap()
 File "winswitch/virt/rdp_client_base.py", line 85, in get_default_keymap
  if k in self.keymaps.keys():
AttributeError: RDPClientUtil instance has no attribute 'keymaps'

I cannot explain why keymaps is not defined...
The RDPClientBase constructor looks like this:

		ClientUtilBase.__init__(self, WINDOWS_TYPE, update_session_status, notify_callback)
		self.ignore_process_returncodes.append(2)		#closing the window causes this returncode!
		if ENABLE_KEYMAP_OPTION:
			self.keymaps = self.find_all_keymaps()
			self.default_keymap = self.get_default_keymap()

(ENABLE_KEYMAP_OPTION is hardcoded to True)
And this constructor is called by the RDPClientUtil constructor..

Change History (1)

comment:1 Changed 7 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

fixed in r4882

Note: See TracTickets for help on using tickets.